[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8304 [Vidalia]: When multiple `SocksPort` options are written in Vidalia's `torrc` dialog window, only the last one is actually written to disk.

#8304: When multiple `SocksPort` options are written in Vidalia's `torrc` dialog
window, only the last one is actually written to disk.
---------------------+------------------------------------------------------
 Reporter:  meitar   |          Owner:  chiiph, malaparte_
     Type:  defect   |         Status:  needs_revision    
 Priority:  normal   |      Milestone:                    
Component:  Vidalia  |        Version:  Vidalia: 0.2.21   
 Keywords:           |         Parent:                    
   Points:           |   Actualpoints:                    
---------------------+------------------------------------------------------

Comment(by malaparte_):

 Replying to [comment:6 arma]:


 > The fix can't be just to make the elements of the hashed table into
 linked lists -- context matters in the torrc file for a few config options
 (like the order in hidden service declarations).

 Solution I'll be providing a patch for still uses a QHash table

 >
 > I think our best bet is to have a simple way to tell Tor that the
 following string is its new config. But really, this is all messy -- do
 you tell Tor to wipe out previous config changes before applying this
 string?

 Current behaviour is to bunch together onto a line before setting. It
 doesn't overwrite previous declarations (telneting to the control port and
 doing SocksPort=1234, newline, SocksPort=4321 over writes, doing
 SocksPort=1234 SocksPort=4321 newline saves both.

 > What if Vidalia had some boxes checked somewhere that e.g. turn you into
 a relay, but you don't have those lines in the torrc box?

 I can't produce this state of affairs. Checking the box tells tor to write
 to the torrc . Vidalia is telling Tor to write to the Torrc, it's not
 writing to the Torrc and then telling Tor to use this. I checked this out
 using GETINFO config-text

 If someone could double check on the HiddenService declaration order is
 fine, that'd be great. I have only read the code to see that it should be
 well ordered.

 5 char patch to follow.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8304#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs