[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8444 [Tor]: "LearnCircuitBuildTimeout 0" is broken when no CircuitBuildTimeout is set (was: Tor in tor2webmode hangs at 10% "Establishing Directory Connection")

#8444: "LearnCircuitBuildTimeout 0" is broken when no CircuitBuildTimeout is set
--------------------------------+-------------------------------------------
 Reporter:  aagbsn              |          Owner:  hellais, naif     
     Type:  defect              |         Status:  needs_review      
 Priority:  major               |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor                 |        Version:  Tor: 0.2.3.25     
 Keywords:  tor-client tor2web  |         Parent:                    
   Points:                      |   Actualpoints:                    
--------------------------------+-------------------------------------------
Changes (by nickm):

  * priority:  normal => major
  * status:  new => needs_review
  * milestone:  Tor: unspecified => Tor: 0.2.3.x-final


Comment:

 It looks to me like this will also affect anybody who has disabled
 LearnCircuitBuildTimeout but not set CircuitBuildTimout.

 I think that the right fix is that
 circuit_build_times_get_initial_timeout() should check whether
 CircuitBuildTimeout is actually set, and if not, we should use a default
 value.

 Try branch "bug8444_v1" in my public repository?  If it works and it
 passes review, I'll add a changes file and a real commit message.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8444#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs