[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #8443 [Tor]: SSL handshake filtered when MAX_SSL_KEY_LIFETIME_ADVERTISED is 365 days
#8443: SSL handshake filtered when MAX_SSL_KEY_LIFETIME_ADVERTISED is 365 days
------------------------+---------------------------------------------------
Reporter: arma | Owner:
Type: defect | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.4.x-final
Component: Tor | Version:
Keywords: tor-bridge | Parent: #3972
Points: | Actualpoints:
------------------------+---------------------------------------------------
Comment(by nickm):
{{{
+ start_time -= (start_time % 24*3600);
}}}
In addition to the order of operations issue here, are we sure it actually
produces the result we expect? Did you look at these certificates and
make sure they come out right? I guess they must, since leap-seconds
aren't included in time_t if I understand correctly.
Other than that, it looks okay to me. If it test out okay, I say we at
least merge into 0.2.4.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8443#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs