[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4600 [Tor]: Spec doesn't mention password quotes

#4600: Spec doesn't mention password quotes
------------------------+---------------------------------------------------
    Reporter:  atagar   |       Owner:  nickm              
        Type:  defect   |      Status:  reopened           
    Priority:  trivial  |   Milestone:  Tor: unspecified   
   Component:  Tor      |     Version:                     
  Resolution:           |    Keywords:  easy spec tor-relay
      Parent:  #4933    |      Points:                     
Actualpoints:           |  
------------------------+---------------------------------------------------
Changes (by atagar):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 Hi Nick. Sorry about re-opening this old ticket but while looking at #8471
 I realized that
 [https://gitweb.torproject.org/torspec.git/commitdiff/9716716527fc5e8047b57f14870afbb3c864a197
 9716716] doesn't match
 [https://gitweb.torproject.org/tor.git/blob/HEAD:/src/common/util.c#l1091
 esc_for_log]. Presently
 [https://gitweb.torproject.org/stem.git/blob/HEAD:/stem/response/__init__.py#l55
 stem escapes the characters] mentioned by esc_for_log.

 Two questions:

 1. Should QuotedString also mention that single quotes, tabs, etc are
 escaped?
 2. rransom mentioned that tor only does escaping in a few specific places,
 are you sure that it's appropriate to say that all QuotedStrings are
 escaped?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4600#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs