[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8435 [Tor]: Ignore advertised bandwidths for flags once we have enough measured bandwidths

#8435: Ignore advertised bandwidths for flags once we have enough measured
bandwidths
-------------------------+--------------------------------------------------
 Reporter:  andrea       |          Owner:                    
     Type:  enhancement  |         Status:  needs_review      
 Priority:  major        |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor          |        Version:  Tor: unspecified  
 Keywords:  tor-auth     |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------
Changes (by andrea):

  * status:  needs_revision => needs_review


Comment:

 Replying to [comment:10 nickm]:
 > Looks good!
 >
 > Does routers_with_measured_bw really need to be static?  Maybe
 dirserv_count_measured_bws could return a value.  That could make things
 ugly, though. If it remains static, though, it should be documented what
 sets it when and what uses it when.

 I think all the plumbing for making it a return value is too icky; I
 improved the comment though.

 > required_mbw should be documented in the doxygen comment for
 router_counts_toward_thresholds
 >
 >  dirserv_query_measured_bw_cache is used like a predicate but isn't
 named like one.  Maybe we should add a dirserv_router_has_measured_bw()
 wrapper for clarity.

 Done.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8435#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs