[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8285 [Flashproxy]: facilitator-email-poller: don't process registrations that are too old

#8285: facilitator-email-poller: don't process registrations that are too old
-------------------------+--------------------------------------------------
 Reporter:  dcf          |          Owner:  dcf
     Type:  enhancement  |         Status:  new
 Priority:  normal       |      Milestone:     
Component:  Flashproxy   |        Version:     
 Keywords:               |         Parent:     
   Points:               |   Actualpoints:     
-------------------------+--------------------------------------------------

Comment(by sukhbir):

 A couple of quick notes about the patch, just in case I missed something:

 * I am assuming a timezone-agnostic approach for both the mail service
 (Gmail in our case, which is PDT/PST) and the local time; both are
 converted to UTC and then compared.
  * To make handling timezone stuff easier, I am using `dateutil`.

 * For the received header, I am taking into account Gmail's "X-Received",
 which is when the message is received by the Gmail servers.

 * To test this patch, you can use `patchtest.py` (attached). Just run it
 and paste the headers (or the entire message), and it will show you
 whether the message is "new" or "old". The same function is used in
 `facilitator-email-poller'.
  * As discussed, this is the easiest way of testing it without having to
 set up an emulation environment.

 Let me know if there any changes to be made.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8285#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs