[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9221 [Obfsproxy]: obfsproxy does not have a SOCKS5 listener

#9221: obfsproxy does not have a SOCKS5 listener
---------------------------+------------------------------
     Reporter:  JBennett   |      Owner:  asn
         Type:  defect     |     Status:  reopened
     Priority:  normal     |  Milestone:
    Component:  Obfsproxy  |    Version:  Obfsproxy: 0.1.4
   Resolution:             |   Keywords:
Actual Points:             |  Parent ID:
       Points:             |
---------------------------+------------------------------
Changes (by yawning):

 * cc: yawning (added)


Comment:

 Bam.

 https://github.com/Yawning/obfsproxy/commit/ebbe9e1167376278b9f4200c34c83f6400e494df

 Things that it needs:
  * Someone should test IPv6, though it should work unless I screwed up
  * If there were any SOCKS unit tests, they're now totally broken
  * When the TCP connect fails outright, it should send the appropriate
 SOCKS5 error codes from the errBack.
  * Cleanups/Review.  (Probably a bunch of style/idiom stuff, I'm not a
 python programmer)

 Things that involve some design work:
  * In an ideal world, each transport would call
 SOCKSv5Protocol.send_reply(code) after the handshake is finished, instead
 of it being called from SOCKSv5Outgoing.connectionMade()

 I was working under the assumption that something that was suitable for
 merging upstream would require monkey patching, so I didn't bother writing
 something that is easy to contribute back up.  They've had the bug open
 for 8 years, they can write their own SOCKS5 server if they want one.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9221#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs