[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9221 [Obfsproxy]: obfsproxy does not have a SOCKS5 listener

#9221: obfsproxy does not have a SOCKS5 listener
---------------------------+------------------------------
     Reporter:  JBennett   |      Owner:  asn
         Type:  defect     |     Status:  needs_review
     Priority:  normal     |  Milestone:
    Component:  Obfsproxy  |    Version:  Obfsproxy: 0.1.4
   Resolution:             |   Keywords:
Actual Points:             |  Parent ID:
       Points:             |
---------------------------+------------------------------

Comment (by asn):

 I reviewed up to `0583a45 More changes based on feedback`. Code looks
 good, ready to merge when it gets a few unittests.

 As a nitpick, why do you use this `methodcaller` thing? Surely the code
 can be easily changed to not require it, right?

 Maybe some docs in `__ByteBuffer` on whether `add_uint32()` (etc.) does it
 in little-endian or big-endian (depending on `htonl`) would also be good.

 Also, `__ByteBuffer:get(self, len)` uses `len` as the name of an argument,
 but `len` is a built-in identifier. btw, such small errors can be found
 easily with pylint.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9221#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs