[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8402 [Tor]: Tor should help its transport proxy use a proxy, if needed.

#8402: Tor should help its transport proxy use a proxy, if needed.
------------------------+--------------------------------------
     Reporter:  asn     |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-bridge pt flashproxy
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------------
Changes (by yawning):

 * status:  needs_revision => needs_review


Comment:

 https://github.com/yawning/tor/tree/bug_8402

 Per discussion:
  * Changes now live in a branch.
  * `PROXY true` -> `PROXY DONE`
  * `mp->acked_proxy` -> `mp->proxy_supported` (I use proxy_uri, so flipped
 the suggested name to be consistent).
  * Duplicate code in `get_proxy_addrport()` moved into
 `get_bridge_pt_addrport()`.
  * Now with unit tests for `get_pt_proxy_uri()`.

 I didn't end up writing a test for the duplicate code I moved into a
 function because I consider that trivial (existing code that was present
 in the pt/bridge if case moved into a separate function).

 I also pushed the one line update to my pyptlib branch that makes it emit
 `PROXY DONE` and it seems to be working as expected.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8402#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs