[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9268 [TorBrowserButton]: Resizing the browser window does not take size of taskbars and DPI into account

#9268: Resizing the browser window does not take size of taskbars and DPI into
account
-------------------------+-------------------------------------------------
     Reporter:  gk       |      Owner:  mikeperry
         Type:  defect   |     Status:  needs_revision
     Priority:  major    |  Milestone:
    Component:           |    Version:
  TorBrowserButton       |   Keywords:  tbb-fingerprinting,
   Resolution:           |  GeorgKoppen201403R, MikePerry201403R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by cypherpunks):

 >For instance, in which cases should the outerHeight and the innerHeight
 be equal? You hint at maximized windows. But even there you have browser
 chrome (toolbars etc.). Maybe you mean fullscreen mode? But even then Tor
 Browser is never starting in fullscreen mode nor with missing browser
 chrome. At least I can currently not think of a use-case in which it would
 do that.

 The outerHeight and the innerHeight be equal if Firefox using gtk widget,
 for maximized and normal windowState.

 >And I don't understand the no window case either. If we have no window
 then there are window properties either.

 It happens for
 [https://gitweb.torproject.org/user/gk/torbutton.git/blob/a8fda403ef16a0f86f76fdee33aff6f79d4eff29:/src/chrome/content/torbutton.js#l3017
 first call] of torbutton_resize_window(win).  Browser reports both
 window.mozInnerScreenY and window.screenY are zero.

 > What's that fancy kludge thingy for?

 For gnome, I believe.

 >Is there something in the Mozilla code that makes you believe there is
 such kind of randomness?
 It doesn't adds height of title bar to window.outerHeight. It's probably
 lack of usage gtk api, however?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9268#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs