[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #11377 [BridgeDB]: New BridgeDB GimpCaptcha should be case insensitive (or should say it's sensitive)

#11377: New BridgeDB GimpCaptcha should be case insensitive (or should say it's
sensitive)
-------------------------+-------------------------------------------------
     Reporter:  wfn      |      Owner:  isis
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:           |    Version:
  BridgeDB               |   Keywords:  bridgedb-dist, bridgedb-https,
   Resolution:           |  easy, gimp-captcha
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------
Changes (by wfn):

 * status:  assigned => needs_review


Comment:

 Replying to [comment:2 isis]:
 > I ''thought'' that most CAPTCHA system are case sensitive, but I could
 be wrong.

 Yeah, those captcha systems are not intuitive at all, right? fwiw, I'd
 have also guessed that most/many of them are case sensitive.

 > I'd accept a patch for either of the proposed fixes.

 Don't know if this helps, but in case it does: I'm linking to a commit (in
 a separate bug branch, `bug11377_gimpcaptcha`) (+ attaching its patch
 file) that makes the check be case insensitive (it's just one line / a few
 bytes. Doesn't break things.)

 https://github.com/wfn/bridgedb/commit/dd9e75ba234d2d4aad90aedb0bf163d8bb13811b

 I'm still learning to tame BridgeDB. Running all tests seem to take a long
 while. But I did run the `test_createChallenge_decryptedAnswerMatches()`
 from `bridgedb.test.test_captcha.GimpCaptchaTests`.

 If this goes well, I assume it'd be nice to create a separate test as
 well, something like
 `test_createChallenge_decryptedAnswerMatchesDifferentCases()` or so?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11377#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs