[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #15211 [Tor]: Audit all asserts to ensure they don't have side effects

#15211: Audit all asserts to ensure they don't have side effects
-----------------------------+--------------------------------
     Reporter:  cypherpunks  |      Owner:
         Type:  defect       |     Status:  needs_review
     Priority:  minor        |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by dgoulet):

 My two cents. This makes the code better for the following reasons thus I
 ack Sebastian patch.

 1) Readability which is important as more and more contributors start
 looking/using the code. I myself doesn't expect function calls in an
 assert() because they can't be removed (not in the case of tor though).
 It's just not something you expect in C code imo.

 2) Maintainability over time, keep the code consistent which often is the
 starting point for new contributors to look at the code to understand the
 coding style before submitting a patch (yes not always the case, I know).

 I absolutely agree, this is not critical but the change is trivial and
 useful imo. Probably the change file could be "Coding style" instead of
 "bugfix" because no bug is fixed here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15211#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs