[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #6411 [Tor]: Adding hidden services through control socket

#6411: Adding hidden services through control socket
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  yawning
  kevinevans             |     Status:  needs_review
         Type:           |  Milestone:  Tor: 0.2.7.x-final
  enhancement            |    Version:  Tor: 0.2.3.19-rc
     Priority:  normal   |   Keywords:  hidden-service control maybe-
    Component:  Tor      |  proposal tor-hs globalleaks-wants
   Resolution:           |  Parent ID:  #8993
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by special):

 A few minor comments on the spec:

 * The spec repeatedly uses 'Onion Services', but all other documentation
 still says 'Hidden services'. The reader may wonder what the difference is
 between these 'Onion Services' and the hidden services they can create via
 the configuration.
 * GET_ONIONS could be a GETINFO command instead, but I can't think of any
 particular benefit to changing it
 * Because GET_ONIONS doesn't return services from other control
 connections, there is no way to comprehensively list services published by
 tor. They're not confidential either, though: those service names can (I
 think) appear in asynchronous events.

 Nothing stands out to me as wrong in the code branch, but I'm not
 qualified to properly review it either.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6411#comment:43>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs