[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #10385 [BridgeDB]: Replace BridgeDB's use of python-gpgme with python-gnupg

#10385: Replace BridgeDB's use of python-gpgme with python-gnupg
--------------------------+--------------------------------------------
     Reporter:  isis      |      Owner:  isis
         Type:  defect    |     Status:  closed
     Priority:  normal    |  Milestone:
    Component:  BridgeDB  |    Version:
   Resolution:  fixed     |   Keywords:  bridgedb-email, bridgedb-0.3.0
Actual Points:            |  Parent ID:
       Points:            |
--------------------------+--------------------------------------------

Comment (by isis):

 There is a minor fix on the above branch, and it is in my `hotfix/10385
 -init-gpg-ret`
 [https://gitweb.torproject.org/user/isis/bridgedb.git/log/?h=hotfix/10385
 -init-gpg-ret branch].

 The fix concerns the return value of the
 `bridgedb.crypto.initializeGnuPG()` function when that function's test
 signature creation code (towards the end of the function) fails.

 When the test signing in `bridgedb.crypto.initializeGnuPG()` fails, the
 return value would be `None`, rather than the gpg interface and the
 signing function, `(gpg, gpgSignMessage)`, or `(None, None)` as it does
 with the other failure modes.  This would cause the EmailServerContext to
 raise a TypeError because `None` is not iterable, and cannot be assigned
 to two variables.

 We now return `(None, None)` when the test signing fails.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10385#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs