[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3523 [Tor]: Allow controllers to post HS descriptors to the HSDir system

#3523: Allow controllers to post HS descriptors to the HSDir system
-----------------------------+-----------------------------------
     Reporter:  rransom      |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  minor        |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  maybe-proposal tor-hs
Actual Points:               |  Parent ID:  #8993
       Points:               |
-----------------------------+-----------------------------------
Changes (by yawning):

 * status:  needs_review => needs_revision


Comment:

 Casual review:

  * (General) This needs a `control-spec.txt` patch documenting the
 behavior.
  * `control.c:handle_control_hspost()`
    * This routine leaks memory like a sieve.
    * `cp = (char*) body;` don't cast off the const.
  * `rendservice.c:directory_post_to_hs_dir()`
    * This needs documentation that it will obliterate the contents of
 `hs_dirs` and free the pointer.
    * Leaks a smartlist_t when hs_dirs != NULL.

 There may be more things wrong, but this should be a start.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3523#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs