[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #3523 [Tor]: Allow controllers to post HS descriptors to the HSDir system
#3523: Allow controllers to post HS descriptors to the HSDir system
-----------------------------+-----------------------------------
Reporter: rransom | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: Tor: 0.2.7.x-final
Component: Tor | Version:
Resolution: | Keywords: maybe-proposal tor-hs
Actual Points: | Parent ID: #8993
Points: |
-----------------------------+-----------------------------------
Comment (by yawning):
Replying to [comment:14 donncha]:
> Thanks for the review. I'm new to C, so apologies for all the rookie
mistakes! I've attempted to fix the memory leaks that I can see. I've
updated the code repo and also pushed a patch for the tor-spec.
No worries, thanks for the code.
> "cp = (char*) body; don't cast off the const". This didn't seem right to
me either. I was following the style of handle_control_postdescriptor(),
where a '\0' is placed at the end of the argument list to stop argument
parsing. As such a need a non const char pointer. What do you think I
should do instead? Copy the argument line into a new char array and the
parse the arguments from that instead?
>
> Thanks again for the review
>
>
https://github.com/DonnchaC/tor/compare/ca03b10b0c39a02fd66824d04deccf40cbd66951...3523
Hmm. Perhaps something like
https://gist.github.com/Yawning/b41f29b6893dcdb83cc1 may resolve the
remaining issues (NB: Untested because I don't have a HS descriptor etc.).
>
https://github.com/DonnchaC/torspec/compare/bc348154c63f46fc6cc56c49d339fcd0aab78f3d...3523
This looks ok to me.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3523#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs