[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18462 [Tor]: Rename tor_dup_addr to make it clear that it returns a string
#18462: Rename tor_dup_addr to make it clear that it returns a string
-------------------------+------------------------------------
Reporter: teor | Owner:
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.2.9.x-final
Component: Tor | Version:
Severity: Normal | Resolution:
Keywords: easy intro | Actual Points:
Parent ID: | Points:
Sponsor: |
-------------------------+------------------------------------
Changes (by teor):
* status: new => needs_revision
Comment:
Thanks for the patch!
Looks great, and does almost exactly what we need it to do.
But in #18454, we'll remove the tor_dup_addr calls in
get_interface_address6_list (we actually want to duplicate the memory, not
format a string). So we don't need to change those at all in this patch.
Would you mind updating the patch to leave the two tor_dup_addr calls in
get_interface_address6_list as they are?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18462#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs