[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18479 [Tor]: Avoid overflow in tor_timegm when time_t is 32 bit
#18479: Avoid overflow in tor_timegm when time_t is 32 bit
---------------------------------------------+-----------------------------
Reporter: teor | Owner:
Type: defect | Status:
Priority: Medium | needs_review
Component: Tor | Milestone: Tor:
Severity: Normal | 0.2.8.x-final
Keywords: integer-overflow security-maybe | Version: Tor:
Parent ID: | unspecified
Sponsor: | Resolution:
| Actual Points:
| Points:
---------------------------------------------+-----------------------------
Changes (by teor):
* keywords: integer-overflow => integer-overflow security-maybe
* status: new => needs_review
Old description:
> tor_timegm overflows for dates in and after 2037 when time_t is 32-bit.
> Instead, we should warn and return an error.
>
> This is a bugfix on 3c4b4c8ca in tor-0.0.2pre14.
New description:
tor_timegm overflows for dates in and after 2038 when time_t is 32-bit.
Instead, we should warn and return an error.
This is a bugfix on 3c4b4c8ca in tor-0.0.2pre14.
--
Comment:
See my branch timegm_overflow on https://github.com/teor2345/tor.git
It adds unit tests for times from 2035 to 2039, for both 32 bit and 64 bit
time_t.
Split off #18480 to fix the semantics of some time functions which don't
indicate failure on overflow.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18479#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs