[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18371 [Tor Browser]: TorBrowser.app.meek-http-helper symlinks incompatible with Gatekeeper signing

#18371: TorBrowser.app.meek-http-helper symlinks incompatible with Gatekeeper
signing
-------------------------+--------------------------------
 Reporter:  mcs          |          Owner:  mcs
     Type:  defect       |         Status:  needs_revision
 Priority:  Medium       |      Milestone:
Component:  Tor Browser  |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:  #13252       |         Points:
  Sponsor:               |
-------------------------+--------------------------------

Comment (by mcs):

 Replying to [comment:5 dcf]:
 > Here are a few minor revisions I'd like to see:
 >  * Copy the profile to a temporary directory (ioutil.TempDir) and rename
 it atomically (os.Rename). Otherwise, the copy could fail halfway through
 but the os.Stat check in ensureProfileExists will be fooled.
 >  * Use filepath.Join to join path instead of string concatenation.
 >  * In copyFile, you can use os.OpenFile to avoid a separate call to
 os.Chmod.

 We made those changes. I will attach a revised patch.

 > How do you want the tags to work? I'm assuming that a meek-client-
 torbrowser using this patch will only work in an alpha TB, not in a
 stable. So I'm thinking of making it a parallel branch, rather than
 extending master. (Maybe this is an argument for moving the meek-client-
 torbrowser code into the tor-browser-bundle repo.)

 I will leave the branch decision to Georg, but yes, this is is an alpha-
 only thing for now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18371#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs