[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18213 [Tor]: The parameter WarnUnsafeSocks does not work as specified in the documentation, no warning is logged in the log file

#18213: The parameter WarnUnsafeSocks does not work as specified in the
documentation, no warning is logged in the log file
-----------------------------------------------+---------------------------
 Reporter:  propropus                          |          Owner:
     Type:  defect                             |         Status:
 Priority:  High                               |  needs_review
Component:  Tor                                |      Milestone:  Tor:
 Severity:  Major                              |  0.2.8.x-final
 Keywords:  WarnUnsafeSocks, Log 027-backport  |        Version:
Parent ID:                                     |     Resolution:
 Reviewer:                                     |  Actual Points:
                                               |         Points:
                                               |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by special):

 I don't know why this was in needs_review. I couldn't find an actual
 patch. propropus' solution would leave the function documentation
 incorrect.

 See my bug18213 branch. I dislike the idea of silently rejecting
 connections when `SafeSocks 1` and `WarnUnsafeSocks 0`, so I downgraded it
 to a notice in that case.

 https://gitweb.torproject.org/user/special/tor.git/commit/?h=bug18213&id=1033043df081d251fa4b227b8046dc9b34aac2d8

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18213#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs