[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18547 [Nyx]: Add hostnames and geoip to connection panel

#18547: Add hostnames and geoip to connection panel
-------------------------+------------------------
 Reporter:  atagar       |          Owner:  atagar
     Type:  enhancement  |         Status:  new
 Priority:  High         |      Milestone:
Component:  Nyx          |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:  connections  |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:  None
-------------------------+------------------------
Changes (by atagar):

 * sponsor:   => None


Comment:

 Just stumbled upon both a complication and an opportunity.

 Earlier this week I pushed a
 [https://gitweb.torproject.org/nyx.git/commit/?id=df0fc05f405e3fbffe0acb28d276e5ef27f5af3e
 'fixed' to prevent curses from flickering]. We called **GETINFO ns/all**
 causing us to read 1.6 MB of data from the local tor process, bogging down
 our interface and disrupting curses.

 On reflection my 'fix' simply broke the ConsensusTracker (_task() is never
 called since it isn't a Daemon subclass). As a result curses now works
 great but we don't have any consensus information, which in effect causes
 us to not show any connections.

 How is this relevant to this issue? Two things...

 1. If we also request **or_addresses** from Onionoo we can move the
 **get_relay_fingerprints()** method from the ConsensusTracker to the
 OnionooTracker. Once we've done this we won't have a need to call
 **GETINFO ns/all**.

 2. The curses flickering will be caused by **any** long-running task.
 Downloading 500 KB of Onionoo data will likely have a similar issue. If so
 we might need to spawn a separate process to do this so the download
 doesn't hog python's GIL.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18547#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs