[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18649 [Tor]: Clarify comments around closing excess consensus connections

#18649: Clarify comments around closing excess consensus connections
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  comment-only must-fix-before-028-rc  |        Version:  Tor:
  TorCoreTeam201603                              |  0.2.8.1-alpha
Parent ID:                                       |     Resolution:
 Reviewer:                                       |  Actual Points:
                                                 |         Points:
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 minor typo, "if the is"

 yes, these comments are good and helpful, thanks. let's merge it.

 also teor, while i'm thinking about it: it looks like we call ourselves
 'not bootstrapping a consensus' if we have one that's 22 hours old. I bet
 we have some logic somewhere to try to get a newer one in that situation.
 It would be a shame for that logic to get cut off by this logic. I haven't
 read enough of the code so hopefully this isn't an issue, but I figured
 I'll raise it just in case.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18649#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs