[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21406 [Core Tor/Tor]: The channel is_client flag is inaccurate

#21406: The channel is_client flag is inaccurate
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.4.23
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  0.5
Parent ID:                |         Points:  0.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_revision => needs_review
 * version:   => Tor: 0.2.4.23
 * actualpoints:   => 0.5


Comment:

 Please see my branch connection-with-client-v2.

 The flag in or_connection_t was unused (there wasn't even an accessor), so
 I removed it with a note about how to get the channel value.

 I added a comment noting that CREATE_FAST is a legacy mechanism for
 checking for clients.

 We can create an accessor for this flag from an or_connection_t when we
 need it. (I suspect that the traffic padding code and custom measurement
 code might be interested in this flag from an or_connection.)

 I also opened another ticket to check for places where we're identifying
 clients by their absence from the consensus: #21585.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21406#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs