[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #21415 [Core Tor/Tor]: tor_bug_occurred_: Bug: src/or/entrynodes.c:1845: select_entry_guard_for_circuit: Non-fatal assertion !(!guard_has_descriptor(guard)) failed.
#21415: tor_bug_occurred_: Bug: src/or/entrynodes.c:1845:
select_entry_guard_for_circuit: Non-fatal assertion
!(!guard_has_descriptor(guard)) failed.
-----------------------------+------------------------------------
Reporter: cypherpunks | Owner: nickm
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor | Version: Tor: 0.3.0.3-alpha
Severity: Normal | Resolution:
Keywords: review-group-16 | Actual Points:
Parent ID: | Points:
Reviewer: asn | Sponsor:
-----------------------------+------------------------------------
Comment (by asn):
OK guys please see my branch `bug21415`.
There is no best solution here, so my branch takes the approach mainly
discussed yesterday in IRC, which is to test 2/3 primary guards for
descriptor, and also remove the BUG() check.
The idea is we test 2/3 and not 3/3 to reduce the performance penalty in
startup (?).
And we remove the BUG() because we know of cases that can cause us to not
have a needed primary guard descriptor if we only check 2/3. If we left
the BUG() in we would get bug reports about these rare cases and we
wouldn't know if it's actually a bug, or just one of the pathological
cases we are aware of.
Please let me know if you hate my patch and suggest alternatives.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21415#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs