[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21459 [Metrics/Atlas]: Make atlas fingerprint selectable by double-clicking



#21459: Make atlas fingerprint selectable by double-clicking
---------------------------+--------------------------------
 Reporter:  teor           |          Owner:  irl
     Type:  defect         |         Status:  needs_revision
 Priority:  Medium         |      Milestone:
Component:  Metrics/Atlas  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:  regression     |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+--------------------------------
Changes (by cypherpunks):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:8 RaBe]:
 > So... What about changing all margins just a bit? We would not need any
 extra classes.
 I agree, this is a better solution.

 > I don't care about the fingerprint wrapping on smaller screens, but I
 can't stand it wrapping just one or two chars in the medium view :D
 I get the frustration because it indeed looks weird to have a few
 characters dangling.

 > (Also I think changing from left to bottom margin even improves the
 detail page's visuals...)
 I would write the rules differently so only specific bootstrap rules are
 overwritten and it would be a little bit more readable. See the inline
 patch for my suggestion.

 {{{
 diff --git a/css/style.css b/css/style.css
 index 9fc862b..5e9000c 100644
 --- a/css/style.css
 +++ b/css/style.css
 @@ -68,9 +68,10 @@ span.flags img {
  }

  dd {
 -    margin:0 0 1.2em 0;
 +    margin-left: 0px;
 +    margin-bottom: 1.2em;
  }

  pre {
 -    padding:5px;
 +    padding: 5px;
  }
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21459#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs