[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21586 [Core Tor/Tor]: Assertion my_rsa_cert failed in sr_generate_our_commit when BridgeAuthoritativeDir 1

#21586: Assertion my_rsa_cert failed in sr_generate_our_commit when
BridgeAuthoritativeDir 1
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:  asn
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.9.9
 Severity:  Normal        |     Resolution:
 Keywords:  tor-sr        |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by asn):

 * status:  assigned => needs_review


Comment:

 The bug here is that we were using `authdir_mode_publishes_statuses()` to
 decide whether to initialize the SR subsystem or not. The problem is that
 that function would also return True if we are `BridgeAuthoritativeDir`
 which is something we don't want.

 Please see fix in my `bug21586` branch. It's as simple as:
 {{{
 /* Setup shared random protocol subsystem. */
 -  if (authdir_mode_publishes_statuses(get_options())) {
 +  if (authdir_mode_v3(get_options())) {
      if (sr_init(1) < 0) {
        return -1;
      }
 }}}

 Let's keep this bug for 0.3.1; it's not critical enough for 0.3.0 IMO.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21586#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs