[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21547 [Applications/Tor Browser]: e10s and 52esr compatibility for tor circuit display

#21547: e10s and 52esr compatibility for tor circuit display
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton,                       |  Actual Points:
  TorBrowserTeam201703R, ff52-esr, tbb-7.0-must  |
Parent ID:  #21201                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mcs):

 Kathy and I reviewed the code and ran it with a browser built from your
 tor-browser.git 20680+4 branch. Circuit display seems to work, but we see
 quite a few messages like this:
  Torbutton INFO: Failed to get credentials or browser from channel

 We modified the code to log the exception and chan.URI.spec. Here is an
 example:
  `[Exception... "Component returned failure code: 0x80004002
 (NS_NOINTERFACE) [nsIInterfaceRequestor.getInterface]"  nsresult:
 "0x80004002 (NS_NOINTERFACE)"  location: "JS frame ::
 chrome://torbutton/content/tor-circuit-display.js :: browserForChannel ::
 line 163"  data: no]`
  uri: https://check.torproject.org/torcheck/img/tor-on.png

 The above error occurred while loading
 https://check.torproject.org/?lang=en_US; we also see similar messages for
 many "internal" fetches such as OSCP which is not as surprising.

 We should figure out a way to suppress the logging for errors that are
 expected. When we do log, we may want to include the exception as well as
 chan.URI.spec to make debugging easier.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21547#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs