[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #21272 [Metrics]: Onionperf deployment
#21272: Onionperf deployment
-------------------------+------------------------------
Reporter: hiro | Owner: metrics-team
Type: enhancement | Status: needs_review
Priority: Medium | Milestone:
Component: Metrics | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------+------------------------------
Comment (by iwakeh):
Replying to [comment:20 karsten]:
> Replying to [comment:19 iwakeh]:
> > Only two short questions about naming scheme and host url:
> >
> > Currently the beginning of the host url is reflected in the file name.
> > Why can't we just use the beginning of the host url, i.e., the op-$cc
part
> > for checking the filenames?
>
> Sure, we could do that. And we could extend that if we need to. Works
for me.
So, all paved for using `getUrlArray`, isn't it?
>
> > Is the goal now to just download all available measurements regarding
file size?
>
> Hmm, I guess the main reason for specifying file sizes explicitly in
`TorperfFilesLines` was that we didn't parse a directory listing, so we
had to know which file sizes exist. But here we do know which file sizes
are measured, so the only reason for specifying those would be to exclude
sizes we don't recognize. Do we have to do that? I'd say as long as the
file sizes stated in the .tpf file name matches the `FILESIZE` value
contained in that file, we'll take what we get.
I think it's fine, to reduce the configuration.
The verification of filename vs. FILESIZE value should be done by
descriptor, if we feel the need to introduce it.
(more about your other comment:18 tomorrow)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21272#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs