Re: [tor-bugs] #21272 [Metrics]: Onionperf deployment

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#21272: Onionperf deployment
-------------------------+------------------------------
 Reporter:  hiro         |          Owner:  metrics-team
     Type:  enhancement  |         Status:  needs_review
 Priority:  Medium       |      Milestone:
Component:  Metrics      |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+------------------------------

Comment (by karsten):

 Replying to [comment:27 iwakeh]:
 > Replying to [comment:26 karsten]:
 > > Replying to [comment:25 iwakeh]:
 > > > Couldn't `downloadFromOnionPerfHost` do some of the filename
 checking before
 > > > calling `downloadAndParseOnionPerfTpfFile`?
 > >
 > > Well, that wouldn't change functionality but would be a simple
 refactoring, right?  What's the goal there?  Make methods more testable or
 easier to read or something else?  In any case, would you want to suggest
 new methods, and I'll move around code?  Or do you want to work on a
 patch?
 >
 > No, I intended to avoid the [https://gitweb.torproject.org/karsten
 /metrics-
 db.git/tree/src/main/java/org/torproject/collector/torperf/TorperfDownloader.java?h=task-21272&id=3318eb8ca769392cca1a6ddc3344c43eba62da91#n750
 superfluous parsing] of the URL for each file and avoid download when the
 filename doesn't make sense.
 > No refactoring.

 Hmm, I'm a bit lost what you mean here.  We only download if the filename
 makes sense.  But this is discussion has become very theoretical.  Want to
 provide a patch? :D

 > > Well, if we moved that code to metrics-lib, users wouldn't be able to
 read Torperf results from anything else than the originally named .tpf
 file.  We usually avoid dependencies on file names if we can.  This case
 is a bit different, because we're archiving .tpf files, and we should be
 certain that they contain what they say.  I'd say that's specific to the
 CollecTor case though and cannot be generalized in metrics-lib.
 >
 > There could be a boolean parameter for strict checking?
 > But, I didn't mean to hijack this ticket.  I can just write that down on
 a list on my desk ;-)

 Sounds like a new ticket.  But I'm not yet sold on the idea.  If it's
 something that only CollecTor needs as provider of .tpf files and none of
 the consumers, then we shouldn't add make it part of metrics-lib.  Of
 course, if there's a plausible use case for consumers, happy to
 reconsider.  But, new (metrics-lib) ticket?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21272#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs