[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #15988 [Applications/Tor Browser]: Update Tor Browser design documentation for 6.5
#15988: Update Tor Browser design documentation for 6.5
-------------------------------------------------+-------------------------
Reporter: gk | Owner: gk
Type: task | Status: closed
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution: fixed
Keywords: tbb-spec, TorBrowserTeam201703R, | Actual Points:
GeorgKoppen201703 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* status: needs_review => closed
* resolution: => fixed
Comment:
Replying to [comment:58 mikeperry]:
> Alright, I think this latest update clarifies and correctly captures the
distinction in how prefetch, preconnect, and speculative connect are all
handled?
Almost. :) The patch you link to is not for `rel="prefetch"` but for
`rel="preconnect"` as the commit message says. In fact, there is a totally
distinct `nsPrefetchService` that is responsible for `rel="prefetch"` and
using the "normal" means of channel creation (see: https://dxr.mozilla.org
/mozilla-esr45/source/uriloader/prefetch/nsPrefetchService.cpp#90) which
we took care of before dealing with `rel="preconnect"`. I tried to capture
that with the following diff:
{{{
-the same mechanism as is used for HTTP Keep-alive. For rel="prefetch", we
-isolate them <ulink
+the same mechanism as is used for HTTP Keep-alive. This is true for
rel="prefetch"
+requests as well. For rel="preconnect", we isolate them <ulink
}}}
I think that is okay and I have squashed my resulting branch into
`bug_15988_v4` (containing updates to the tor browser links and a version
bump to 6.5.1, too).
This is at the same time commit 38086eefafcd63e8e3399534211feea55798fcbe
on `master`.
If there is something I messed up of left, please file follow-up bugs.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15988#comment:59>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs