[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19316 [Applications/Tor Browser]: Make sure our updates are dealing with SSE requirement properly
#19316: Make sure our updates are dealing with SSE requirement properly
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: task | Status:
| needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ff52-esr, tbb-7.0-must, | Actual Points:
TorBrowserTeam201703 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* status: new => needs_revision
Comment:
Replying to [comment:7 boklm]:
> Replying to [comment:1 mcs]:
> > Similar to the minSupportedOSVersion update manifest attribute that we
added for the Mac OS 10.6 issue (see
https://trac.torproject.org/projects/tor/ticket/13047#comment:3), we
should add support for a new attribute such as: `minInstructionSet="SSE2"`
>
> I attached a first version of a patch to do that, but I did not test it
yet, so it may not work.
>
> I think there will still be an issue with people upgrading to the new
ESR52 version from Tor Browser <= 6.5.1 (skipping the version that added
support for the minInstructionSet attribute), as their browser will not
know this attribute. If we want to avoid this, we will need to change the
`update_2` from the updates URL to `update_3` (similar to what we did in
#13047).
The plan sounds good to me. I think we should be less strict here, though:
it seems SSE2 is only required for Windows builds with ESR 52. The Linux
bug is https://bugzilla.mozilla.org/show_bug.cgi?id=1274196 which will
land in Firefox 53. I am not sure about OS X. The tracking bug for the
update on Mozilla's side is:
https://bugzilla.mozilla.org/show_bug.cgi?id=1274196 and there is a way to
detect SSE2 support for Linux using UpdateUtils code included in Firefox:
https://bugzilla.mozilla.org/show_bug.cgi?id=1277359.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19316#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs