[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #21641 [Core Tor/Tor]: Prop274: Rotate onion keys less frequently
#21641: Prop274: Rotate onion keys less frequently
-------------------------------+------------------------------------
Reporter: nickm | Owner: ahf
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: TorCoreTeam201703 | Actual Points: 2.1
Parent ID: | Points: 2
Reviewer: nickm | Sponsor: Sponsor4
-------------------------------+------------------------------------
Changes (by nickm):
* status: needs_review => needs_revision
* reviewer: => nickm
Comment:
Looks good!
Suggestions:
* When a time interval (like MIN/MAX/DEFAULT_ONION_KEY_LIFETIME) has a
unit other than seconds, put the unit in the name. (eg,
"MIN_ONION_KEY_LIFETIME_DAYS"). Otherwise people tend to assume seconds.
Same for DEFAULT/MIN onion_key_grace_period.
* Maybe we should check whether the onion key is expired more
frequently than the get_onion_key_lifetime() interval? -- otherwise, if
the interval changes in the consensus, we won't reach the interior of
rotate_onion_key_callback(). Same for the other callback.
* The documentation for expire_old_onion_keys should make it clear that
the function doesn't perform a grace period check.
* This branch needs a changes file.
(Also please remember when you make these changes, fixup commits are
easier to review than a completely new or rebased branch.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21641#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs