[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21723 [Applications/Tor Browser]: Fix inconsistent generation of MOZ_MACBUNDLE_ID

#21723: Fix inconsistent generation of MOZ_MACBUNDLE_ID
--------------------------------------+------------------------------
 Reporter:  teor                      |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201703R     |  Actual Points:
Parent ID:  #17670                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------

Comment (by mcs):

 Replying to [comment:6 teor]:
 > The build change `--with-distribution-id=org.torproject` changes the
 distribution ID on all platforms. I'm not sure how the distribution ID is
 used on Linux or Windows, but we should be consistent.

 I agree that we should be consistent (unless we find a good reason not to
 be). Here are the references to MOZ_DISTRIBUTION_ID (which is what --with-
 distribution-id sets):
 https://dxr.mozilla.org/mozilla-esr52/search?q=MOZ_DISTRIBUTION_ID

 Files such as browser/branding/aurora/locales/moz.build use
 MOZ_DISTRIBUTION_ID to define MOZ_DISTRIBUTION_ID_UNQUOTED, but I do not
 see where that is used.

 In old-configure.in, MOZ_DISTRIBUTION_ID is used to define
 MOZ_MACBUNDLE_ID, as teor pointed out.

 The code in toolkit/xre/nsAppRunner.cpp makes the MOZ_DISTRIBUTION_ID
 value available via nsIXULRuntime.distributionID. Chasing that via:
 https://dxr.mozilla.org/mozilla-esr52/search?q=distributionID
 shows that it is used in telemetry and in the search engine code. We don't
 care about telemetry, but the search engine code will insert the
 distribution ID into search parameters via `{moz:distributionID}`. But the
 only place I see that technique used is in browser/locales/searchplugins
 /yahoo-jp-auctions.xml, which I assume we will not ship with Tor Browser.

 So... I think it is okay to change the distribution ID on all platforms.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21723#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs