[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25112 [Applications/Tor Browser]: Tor Browser 7.5 is not working on Windows Vista 64bit
#25112: Tor Browser 7.5 is not working on Windows Vista 64bit
-------------------------------------------------+-------------------------
Reporter: gk | Owner:
| pospeselr
Type: defect | Status:
| needs_review
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Major | Resolution:
Keywords: ff60-esr-will-have, | Actual Points:
TorBrowserTeam201803R |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by mcs):
I don't have a way to test this patch, but it looks okay. I have a couple
of comments:
- To match Mozilla's style inside `GeckoChildProcessHost.cpp` you should
add a space after the `if` keywords.
- It is okay to check for the existence of `IsWow64Process()` but I think
it will be present in all versions of Windows we care about since I am
pretty sure we required WinXP sp2 or later. That said, I am not sure what
happens if you try try to run on something older so maybe we should keep
the `GetProcAddress` fun.
- I don't think having `TweakSandboxLevel()` adds much; I would just put
code like this inside `GeckoChildProcessHost::PrepareLaunch()`:
{{{
if (ShouldLowerSandboxLevel(mSandboxLevel)) {
mSandboxLevel = 0;
}
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25112#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs