Re: [tor-bugs] #25432 [Core Tor/Tor]: remove router.c internal functions from router.h

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#25432: remove router.c internal functions from router.h
---------------------------+------------------------------------
 Reporter:  valentecaio    |          Owner:  valentecaio
     Type:  enhancement    |         Status:  assigned
 Priority:  Low            |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor   |        Version:
 Severity:  Minor          |     Resolution:
 Keywords:  easy refactor  |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------------------

Comment (by valentecaio):

 Since each group A function would only be used once, by the respective
 group B function, I suggest that we suppress the group A.

 So, I would do the following:

 1- remove group A functions from header file.
 2- merge group A functions into group B functions (remove declarations of
 group A functions).
 3- remove format_node_description() declaration from header file.
 4- move NODE_DESC_BUF_LEN constant from header to source file.
 5- replace the external call (there is only one) to
 router_get_description() by a call to router_describe().

 What do you think about this?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25432#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs