[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25368 [Core Tor/Tor]: Update the Tor Rust coding standards for new types



#25368: Update the Tor Rust coding standards for new types
----------------------------------------+----------------------------------
 Reporter:  teor                        |          Owner:  teor
     Type:  defect                      |         Status:  merge_ready
 Priority:  Medium                      |      Milestone:  Tor:
                                        |  0.3.4.x-final
Component:  Core Tor/Tor                |        Version:
 Severity:  Normal                      |     Resolution:
 Keywords:  doc, rust, review-group-34  |  Actual Points:
Parent ID:  #23061                      |         Points:  0.5
 Reviewer:  isis                        |        Sponsor:
----------------------------------------+----------------------------------
Changes (by catalyst):

 * cc: catalyst (added)


Comment:

 I talked briefly with komlo about the `Stringlist` thing and it seems like
 she wanted to do the simpler thing of a smartlist of strings because doing
 the generic thing correctly might take significantly more work and not
 necessarily be right on the first try.

 I would be in favor of a ticket for a longer term plan to try to get the
 generic Rust representation of a smartlist right.  I don't have enough
 background to open a ticket myself on the issue.  (Also sorry if I
 misremember the details of what komlo told me.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25368#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs