[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20887 [Core Tor/Tor]: DIRCACHE_MIN_MEM_MB does not stringify on FreeBSD, we should use %d instead

#20887: DIRCACHE_MIN_MEM_MB does not stringify on FreeBSD, we should use %d instead
------------------------------------------------+--------------------------
 Reporter:  teor                                |          Owner:  (none)
     Type:  defect                              |         Status:
                                                |  needs_revision
 Priority:  Medium                              |      Milestone:  Tor:
                                                |  0.3.4.x-final
Component:  Core Tor/Tor                        |        Version:  Tor:
                                                |  0.2.8.1-alpha
 Severity:  Normal                              |     Resolution:
 Keywords:  easy, refactor, logging, tor-relay  |  Actual Points:
Parent ID:                                      |         Points:
 Reviewer:                                      |        Sponsor:
------------------------------------------------+--------------------------
Changes (by nickm):

 * status:  merge_ready => needs_revision
 * milestone:  Tor: unspecified => Tor: 0.3.4.x-final


Comment:

 There's a problem with this patch -- it removes the blank spaces before
 the quotation marks at the end of some of the lines.  Without those blank
 spaces, there will not be appropriate spacing between words in the log
 message.

 For example, this code
 {{{
      tor_asprintf(msg, "Being a directory cache (default) with less than"
                        "%d MB of memory is not recommended and may
 consume"
                        "most of the available resources, consider
 disabling "
                        "this functionality by setting the DirCache option
 "
                        "to 0.", DIRCACHE_MIN_MEM_MB);
 }}}
 will produce a log message beginning with:
 > Being a directory cache (default) with less than300 MB of memory is not
 recommended and may consumemost of the available resources...

 Note the "than300" and "consumemost" problem.

 Also, while we're changing this, let's replace the comma before "consider"
 with a period: those are two separate sentences.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20887#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs