[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #22594 [Metrics/Onionoo]: Escape characters in contact lines break hourly updater
#22594: Escape characters in contact lines break hourly updater
-----------------------------+--------------------------
Reporter: karsten | Owner: iwakeh
Type: defect | Status: accepted
Priority: High | Milestone:
Component: Metrics/Onionoo | Version:
Severity: Normal | Resolution:
Keywords: metrics-2018 | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+--------------------------
Changes (by iwakeh):
* status: needs_revision => accepted
Comment:
Replying to [comment:14 karsten]:
> Looks good! Two things:
> - Can you add a change log entry? Maybe something like this: ''Don't
attempt to un-escape character sequences in contact lines (like "\uk")
that only happen to start like escaped utf-8 characters (like "\u0055").''
Yep, that was missing.
> - There's similar code where we replace `"\\\\u"` with `"\\u"` in
`ResponseBuilder`. Does it make sense to use the new method there, too?
Sure. I was actually intending to add a new ticket about having all
un/escape logic as well as the json-reading and writing in one place,
which would make it easier to switch to some other JSON lib than gson in
future and have the logic separate for re-processing files etc.
But, it's fine to start with putting all un/escape logic in one place and
add the remaining to a new ticket in case it would be too much for one
ticket.
>
> Thanks!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22594#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs