[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18342 [Metrics/Onionoo]: Provide more accurate reverse DNS results
#18342: Provide more accurate reverse DNS results
-----------------------------+--------------------------
Reporter: cypherpunks | Owner: irl
Type: defect | Status: accepted
Priority: Medium | Milestone:
Component: Metrics/Onionoo | Version:
Severity: Normal | Resolution:
Keywords: metrics-2018 | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+--------------------------
Comment (by irl):
I really don't like the `dns_ptr` name for the field. I think Onionoo
works at a higher level than that. I think I definitely prefer the
`unverified_host_name` and `host_name` approach. To get the behaviour
you're looking for in JavaScript would be:
{{{
dns_ptr = relay['host_name'] || relay['unverified_host_name'];
}}}
or Python:
{{{
dns_ptr = relay.get('host_name', None) or
relay.get('unverified_host_name', None)
}}}
The approach where you have dns_ptr and host_name means that when
correctly configured, the host name would end up included twice. I just
don't feel that that's the most elegant solution.
I'll take a look at a patch for the spec later this week, but to outline:
* For `host_name` we implement the spec as it is (actually omitting the
field instead of returning IP addresses).
* For `unverified_host_name`, this will include the DNS PTR record's name.
It would be updated at the same time as the host_name record. Omitted if
the host name was verified by looking up an A record, or if no PTR record
was found.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18342#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs