[tor-bugs] #25613 [Obfuscation/meek]: Close child's stdout to signal exit in meek-client-torbrowser

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#25613: Close child's stdout to signal exit in meek-client-torbrowser
----------------------------------+-----------------
     Reporter:  dcf               |      Owner:  dcf
         Type:  enhancement       |     Status:  new
     Priority:  Low               |  Milestone:
    Component:  Obfuscation/meek  |    Version:
     Severity:  Normal            |   Keywords:
Actual Points:                    |  Parent ID:
       Points:                    |   Reviewer:
      Sponsor:                    |
----------------------------------+-----------------
 Moved from #24642.

 > Another (possibly better) option is to call `cmd.StdinPipe()` and just
 never close the pipe (that way the child process's stdin is separate from
 the parent's, so you don't have a race between them trying to terminate
 when the stdin is closed).

 > The [https://gitweb.torproject.org/pluggable-
 transports/meek.git/log/?h=bug24642 bug24642] branch uses the `StdinPipe`
 idea.
 >
 > I'm not totally happy with it, because ideally according to pt-spec, we
 should keep track of the stdin handle, and close it before sending
 anything like SIGTERM to the subprocess. But that would require more
 rewriting and is more than you need right now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25613>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs