[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24455 [Core Tor/Tor]: messages out of order in the tor log due to stored logs
#24455: messages out of order in the tor log due to stored logs
-------------------------------------------------+-------------------------
Reporter: darkk | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone: Tor:
| unspecified
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: security-low, 033-triage-20180320, | Actual Points:
033-removed-20180320 |
Parent ID: | Points: 0.5
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by arma):
I agree with darkk that having log lines with out-of-order times looks
weird.
I wonder if we could resolve it by writing another message, something like
"Replaying queued log items:" and "Done replaying queued log items"?
That way we can keep on writing our first log line as the 'opening log'
one. After all, if we write the queued log items first and then write the
'opening new log file' line after that, somebody else will point out that
*that's* a weird order.
All of this said, we're going to have some weird-looking behavior
somewhere still. For example, for the controller events, I think we don't
write that "opening new log file" event, so for the controller it just
looks natural that we start up and output the queued events, and having
the controller see stuff about replaying queued log items could confuse
somebody too.
Hm!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24455#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs