[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25386 [Core Tor/Tor]: fix rust tests

#25386: fix rust tests
-------------------------------------------------+-------------------------
 Reporter:  Hello71                              |          Owner:  Hello71
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, tor-test, 033-backport,        |  Actual Points:
  review-group-34                                |
Parent ID:                                       |         Points:  3
 Reviewer:  isis                                 |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------

Comment (by isis):

 Replying to [comment:26 isis]:
 > Oh, it also looks like your branch before squashing was failing when
 compiled with ASan? https://travis-
 ci.org/isislovecruft/tor/builds/357186429
 >
 > Locally I was configuring with `--enable-rust --enable-cargo-online-mode
 --enable-fatal-warnings`, and forgot to use `--enable-expensive-
 hardening`.
 >
 > Will check out the new branch and test that now.

 Okay, ASan is still failing here, and we discussed potential solutions in
 IRC a bit:

 1. Additionally build a libtor.so (and libtool-ise it?) and link it in
 when compiling with `cargo test`.
 2. Keep the original way that we're currently doing things in
 `src/rust/test_rust.sh`, but also add Hello71's branch here with a
 configure flag `--enable-testing-c-from-rust` (which sets `--disable-
 expensive-hardening`) and then we add a row/build to the CI build matrixes
 for additionally running that. (Potentially removing one of the cargo
 offline builds, since having two is a little overly-redundant… but that's
 a separate issue to this one.)
 3. Other not-as-good ideas were discussed.

 Any other ideas? Which of these sounds like a saner way forward?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25386#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs