[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21850 [Applications/Tor Browser]: Update #16940 patch for e10s (about:tbupdate)

#21850: Update #16940 patch for e10s (about:tbupdate)
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-7.0-must,    |  Actual Points:
  TorBrowserTeam201803R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_information


Comment:

 Nice work! One thing I don't understand: why do you have
 {{{
 +if (AppConstants.TOR_BROWSER_UPDATE) {
 +  XPCOMUtils.defineLazyModuleGetter(this, "AboutTBUpdate",
 +    "resource:///modules/AboutTBUpdate.jsm");
 +}
 }}}
 in `browser.js`? It seems you don't use anything from that module there.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21850#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs