[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #25639 [Core Tor/Tor]: merge Rust crates
#25639: merge Rust crates
------------------------------+------------------------------
Reporter: Hello71 | Owner: (none)
Type: enhancement | Status: new
Priority: High | Milestone:
Component: Core Tor/Tor | Version: Tor: unspecified
Severity: Normal | Keywords:
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
------------------------------+------------------------------
pros:
- simpler is better
- makes testing Rust a lot easier, otherwise there are problems with
dependencies. see #25386 for more details
- makes it easier for newbies. I was certainly very confused as to why
each crate only has a single real file.
cons:
- I discussed this on IRC with Sebastian, since it looks like he was the
one who started splitting them up in the first place. he said he doesn't
remember exactly why, but possibly it had something to do with a plan to
swap in and out each crate individually, or possibly something to do with
technical reasons regarding allocation or some such thing. I can't find
anything regarding the latter, and I'm not convinced that the former is
actually helpful.
therefore, if nobody has any objections, I propose moving all the Rust
code into one crate. I asked on IRC, and somebody said that a ticket is
better than mailing list, but I'm happy to copy and paste this into an
email if that's better.
setting priority High since this blocks fixing #25386 with asan (unless
anybody can think of better ways to do that), and that blocks proper Rust
development.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25639>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs