Re: [tor-bugs] #25284 [Core Tor/Tor]: hidden-service-dir description in dir-spec should reference HSDir protovers

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#25284: hidden-service-dir description in dir-spec should reference HSDir protovers
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-spec, dir-spec, tor-hs,          |  Actual Points:
  034-triage-20180328, 034-removed-20180328      |
Parent ID:                                       |         Points:  0.1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by dgoulet):

 Woa... damn I wasn't aware of this `VersionNum` value from the `hidden-
 service-dir` line!... Phrack, we should then change the spec or start
 advertising versions!

 But actually, it doesn't seem our code supports `VersionNum`, it just
 flags the "ri":

 {{{
 T01("hidden-service-dir",  K_HIDDEN_SERVICE_DIR,  NO_ARGS, NO_OBJ ),
   if (find_opt_by_keyword(tokens, K_HIDDEN_SERVICE_DIR)) {
     router->wants_to_be_hs_dir = 1;
   }
 }}}

 Ok, so maybe removing that `VersionNum` from the spec is the move and rely
 solely on protover.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25284#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs