[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #15826 [Obfuscation/Pluggable transport]: Check and return error values in goptlib

#15826: Check and return error values in goptlib
---------------------------------------------+------------------------
 Reporter:  gsathya                          |          Owner:  (none)
     Type:  defect                           |         Status:  closed
 Priority:  Medium                           |      Milestone:
Component:  Obfuscation/Pluggable transport  |        Version:
 Severity:  Normal                           |     Resolution:  fixed
 Keywords:  goptlib                          |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+------------------------
Changes (by dcf):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I added the checks to `s.SetDeadline` and `f.Close`, and added tests for a
 failing `s.SetDeadline`, in this series of commits:
  * https://gitweb.torproject.org/pluggable-
 transports/goptlib.git/diff/?id=3be4b5e2d3ba2add44e0d0307ad3f2487f8ad208&id2=737bb08d9520b27030c32884b0303c389b407671
 I decided that it's not worth breaking out a test for a failing `f.Close`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15826#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs