[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28566 [Core Tor/sbws]: Report relays that sbws sees in the consensus, but never chooses to test

#28566: Report relays that sbws sees in the consensus, but never chooses to test
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  juga
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  sbws:
                                                 |  1.1.x-final
Component:  Core Tor/sbws                        |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-bwauth, sbws-1.0-must-           |  Actual Points:
  moved-20181128                                 |
Parent ID:  #28547                               |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Hi!  I've made some small suggestions throughout the code. It's a little
 tricky to follow, but I think documenting functions will fix that.  Also,
 I'd strongly suggest documenting what _exactly_ each new field should
 contain.  Once that's done you should feel free to merge.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28566#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs