[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29060 [Core Tor/Tor]: shellcheck: test-network.sh issues

#29060: shellcheck: test-network.sh issues
-------------------------------------------------+-------------------------
 Reporter:  rl1987                               |          Owner:  rl1987
     Type:  defect                               |         Status:
                                                 |  reopened
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  technical-debt, regression,          |  Actual Points:
  041-must                                       |
Parent ID:                                       |         Points:
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  closed => reopened
 * keywords:  technical-debt => technical-debt, regression, 041-must
 * resolution:  fixed =>


Comment:

 Replying to [comment:10 rl1987]:
 > In c346eff223e94b5fbeb6e751a99393fc5f7dd4b0 I'm trying to walk away from
 requiring bash by removing the `ORIGINAL_ARGS` array/variable.
 >
 > Not sure I'm not breaking something here. Why did we save `$@` into a
 variable in the first place?

 Because test-network.sh uses shift to search the arguments for the chutney
 path and tor dir. And shift (partially) destroys `$@`.

 Please revert commit c346eff223.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29060#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs