[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29575 [Applications/Tor Browser]: Configure Firefox Project to Use New TOPL Dependencies

#29575: Configure Firefox Project to Use New TOPL Dependencies
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, TBA-a3,                  |  Actual Points:
  TorBrowserTeam201903, tbb-8.5                  |
Parent ID:  #27609                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Initial commit android-0309
 https://github.com/sisbell/tor-browser-build/commits/android-0309

 Android build is definitely different in how it packages files from the
 libs directory and how it packages remote dependencies. Generally this
 difference is OK if we are only using classes and not resources from the
 libraries. Resources seem to be non-transitive, meaning these resource
 aren't accessible if more than one hop away.

 Given that we use resources from tor-android-service -> orbot -> firefox,
 then firefox (two hops) complains about missing resources, while Orbot
 (one hop) is fine. If we attempt to directly include tor-android-service
 in the firefox project, proguard fails because orbot has already included
 tor-android-services in its own class.jar file (duplicate classes
 problem).

 To solve this problem, orbot project will manually remove tor-android-
 service classes from its library before packaging and then we can safely
 included tor-android-service in the firefox project. This solves the
 missing resources and the duplicate file problem.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29575#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs