[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29221 [Core Tor/Tor]: Tooling to track code-style/best-practices violations

#29221: Tooling to track code-style/best-practices violations
--------------------------------------------+------------------------------
 Reporter:  nickm                           |          Owner:  (none)
     Type:  defect                          |         Status:  needs_review
 Priority:  Medium                          |      Milestone:
Component:  Core Tor/Tor                    |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  network-team-roadmap-2019-Q1Q2  |  Actual Points:
Parent ID:                                  |         Points:  3
 Reviewer:  nickm                           |        Sponsor:
                                            |  Sponsor31-can
--------------------------------------------+------------------------------

Comment (by nickm):

 LGTM, except that I think one of the requested changes is important for
 correctness.  I've added a commit for that, plus another commit for the
 message change, in a new PR: https://github.com/torproject/tor/pull/782

 If you like that, let's squash and merge.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29221#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs